[Piglit] [PATCH] arb_compute_variable_group_size: Fix require section.

[Dylan Baker]

Quoting Matt Turner (2016-10-17 13:33:11)
> On Mon, Oct 17, 2016 at 12:54 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
> >
> >
> > On 10/17/2016 09:45 PM, Samuel Pitoiset wrote:
> >>
> >> Thanks for fixing this.
> >>
> >> Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> >
> >
> > Actually, we need to check for both ARB_compute_shader and
> > ARB_compute_variable_group_size since
> > https://cgit.freedesktop.org/mesa/mesa/commit/?id=8785a8ff8948385a913e9bd75e8cdd1092bd750f.
> 
> Strange. Shouldn't a [compute shader] section (or requiring
> GL_ARB_compute_variable_group_size) be sufficient?

No, [computer shader] doesn't imply the requirement. The way shader runner is
implemented it checks the [require] block, then if everything seems good starts
compiling and linking, and doesn't expect errors. So you either need the GL/GLSL
version to imply the extension or to ask for it explicitly.

The fast skipping code in the python layer has the same limitations

Dylan

> 
> I'll make the change regardless.
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20161017/a180df92/attachment.sig>