[Piglit] [PATCH 1/2] framework: change 'regressions' to mean 'regressions in the last test run'

Dylan Baker dylan at pnwbakers.com
Tue Oct 25 20:06:50 UTC 2016

Quoting Marek Olšák (2016-10-25 03:41:15)
> On Mon, Oct 24, 2016 at 8:09 PM, Dylan Baker <dylan at pnwbakers.com> wrote:
> > I agree with Ilia that making regressions and fixes non-symmetric is bad. So at
> > the very least I'd want to see the same change to fixes.
> >
> > The regressions page was designed that someone could run piglit using "git
> > rebase -x" and see what was regressing at each step along the way, and this
> > change would definitely break that workflow. Wether anyone does that (or
> > something like it) I don't know.
> Totally not true. :) It was originally designed to compare 2 runs and
> show transitions such as {pass,skip} -> {fail, crash} and {fail} ->
> {crash}.
> If this series doesn't change the behavior when comparing 2 runs, it's
> OK with me.
> Marek

Okay, since you wrote the original implementation that's fair.

That *was* my workflow for testing this feature when I rewrote the summary code
the second time. 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20161025/eeb9b89e/attachment.sig>

More information about the Piglit mailing list