[Piglit] [Bug 97951] New: piglit_drm_dma_buf.c:142:7: error:=?UTF-8?Q?=20=E2=80=98DRM=5FFORMAT=5FR8=E2=80=99=20undeclared=20?=(first use in this function)

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Sep 27 16:30:41 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=97951

            Bug ID: 97951
           Summary: piglit_drm_dma_buf.c:142:7: error: ‘DRM_FORMAT_R8’
                    undeclared (first use in this function)
           Product: piglit
           Version: unspecified
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Keywords: bisected, regression
          Severity: normal
          Priority: medium
         Component: tests
          Assignee: piglit at lists.freedesktop.org
          Reporter: vlee at freedesktop.org
        QA Contact: piglit at lists.freedesktop.org
                CC: eric at anholt.net, krh at bitplanet.net,
                    robclark at freedesktop.org

piglit: 0222f5db00fd47fb745402514a6d8cf2747f8434 (master)

tests/util/piglit-framework-gl/piglit_drm_dma_buf.c: In function
‘piglit_intel_buf_create’:
tests/util/piglit-framework-gl/piglit_drm_dma_buf.c:142:7: error:
‘DRM_FORMAT_R8’ undeclared (first use in this function)
  case DRM_FORMAT_R8:
       ^
tests/util/piglit-framework-gl/piglit_drm_dma_buf.c:142:7: note: each
undeclared identifier is reported only once for each function it appears in
tests/util/piglit-framework-gl/piglit_drm_dma_buf.c:145:7: error:
‘DRM_FORMAT_GR88’ undeclared (first use in this function)
  case DRM_FORMAT_GR88:
       ^
tests/util/piglit-framework-gl/piglit_drm_dma_buf.c:146:7: error:
‘DRM_FORMAT_RG88’ undeclared (first use in this function)
  case DRM_FORMAT_RG88:
       ^


0222f5db00fd47fb745402514a6d8cf2747f8434 is the first bad commit
commit 0222f5db00fd47fb745402514a6d8cf2747f8434
Author: Rob Clark <robdclark at gmail.com>
Date:   Sat Sep 3 15:16:31 2016 -0400

    dmabuf: fix YUV tests for drivers other than intel

    Ok, so the basic problem with the YUV tests is that they currently
    completely ignore driver/hw pitch requirements, since the code that
    allocates the buffer doesn't know the pixel format, only the 'cpp'.

    The yuv test creates a small 4x4 yuv eglimage.  If, say, the hardware
    requires the pitch to be aligned to, say, 32pixels, everything is fine
    for the Y plane, but the subsampled U/V or U+V plane has half as many
    pixels.  (This did help me catch a bug in driver, not rejecting the
    dmabuf import with invalid pitch, but that doesn't help to get the
    piglit tests running.)

    The best approach I could come up with to fix this is to pass the
    fourcc all the way down to the code that creates the dmabuf (and copies
    src data into the dmabuf).  Unfortunately this makes the patch a bit
    bigger than I was hoping, and not really sure a good way to split it
    up.

    This is tested on i965 (with the intel dma-buf backend) and freedreno
    (with the gbm dma-buf backend).  In the gbm case, it requires new
    gbm format values for R8 and GR88, which is on mesa master as of
    this morning.  (So I bumped the gbm version dependency to 12.1.)

    Signed-off-by: Rob Clark <robdclark at gmail.com>
    Reviewed-by: Eric Anholt <eric at anholt.net>
    Reviewed-by: Kristian Høgsberg <krh at bitplanet.net>

:100644 100644 ce7f3f8aabc4884550b4d62ae738b8ed49a13131
4002fe9bf741e43377221021ade5faa51c3dea60 M      CMakeLists.txt
:040000 040000 1cb176b53c8e3ed014824612b498e64c1fb393fc
7730a34ffac6886e43c48bd6b8df7ae3bb700d4b M      tests
bisect run success

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160927/9c137856/attachment.html>


More information about the Piglit mailing list