[Piglit] [Bug 97951] piglit_drm_dma_buf.c:142:7: error:=?UTF-8?Q?=20=E2=80=98DRM=5FFORMAT=5FR8=E2=80=99=20undeclared=20?=(first use in this function)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=97951

--- Comment #10 from Rob Clark <robclark at freedesktop.org> ---
(In reply to Dylan Baker from comment #9)
> 
> Err, that should be "if the GBM version is *not* new enough"

(In reply to Dylan Baker from comment #8)
> 
> I think the problem is further down:
> 
> if(LIBDRM_FOUND AND XCB_DRI2_FOUND AND
>    ((LIBDRM_INTEL_VERSION VERSION_GREATER "2.4.37") OR
>      PIGLIT_HAS_GBM_BO_MAP))
> 	set(PIGLIT_BUILD_DMA_BUF_TESTS_IS_VALID true)
> else()
> 	set(PIGLIT_BUILD_DMA_BUF_TESTS_IS_VALID false)
> endif()
> 
> This will do what you expect on every piece of hardware, except Intel, where
> if the GBM version is new enough it will still turn it on if the DRM_INTEL
> version is also new enough.
> 
> I think we just need to remove that LIBDRM_INTEL check (or modify it).

oh, my bad.. I read the error message too quickly, as GBM_FORMAT_R8/etc.. not
DRM_FORMAT_xyz.  So that part won't be built unless you have
-DPIGLIT_HAS_GBM_BO_MAP, so existing check is fine.

The problem is actually that he has too old drm_fourcc.h I guess?  Not sure
what the best way to check for that would be..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20160927/6322089b/attachment.html>