[Piglit] [PATCH v2 0/5] Add tests for ARB_bindless_texture

Samuel Pitoiset samuel.pitoiset at gmail.com
Fri Apr 7 16:58:56 UTC 2017


Hi,

Changes from RFC:
 - added new execution tests (mostly for images)
 - removed wrong (and useless) linker tests
 - fixed some compiler and API tests
 - removed some extra error checks in the API tests

Compared to the RFC, the passrate is similar with NV. On my side, the
passrate is now at 92% with Mesa. The remaining fails are mostly GLSL
explicit conversions which are still not really supported (I'm working on).

Happy reviewing,
Thanks!

Samuel Pitoiset (5):
  shader_runner: add support for ARB_bindless_texture
  add API-related tests for ARB_bindless_texture
  arb_bindless_texture: add compiler-related tests
  arb_bindless_texture: add linker-related tests
  arb_bindless_texture: add execution-related tests

 tests/all.py                                       |  14 +
 tests/shaders/shader_runner.c                      |  92 ++++
 tests/spec/CMakeLists.txt                          |   1 +
 tests/spec/arb_bindless_texture/CMakeLists.gl.txt  |  23 +
 tests/spec/arb_bindless_texture/CMakeLists.txt     |   1 +
 tests/spec/arb_bindless_texture/border-color.c     | 217 +++++++++
 tests/spec/arb_bindless_texture/common.c           |  42 ++
 tests/spec/arb_bindless_texture/common.h           |  32 ++
 .../compiler/images/arith-expr.vert                |  32 ++
 .../images/bindless-global-and-bound-global.vert   |  26 +
 .../compiler/images/bindless-global.vert           |  25 +
 .../compiler/images/bindless-local.vert            |  25 +
 .../compiler/images/bindless-nonuniform.vert       |  23 +
 .../compiler/images/bound-global.vert              |  25 +
 .../compiler/images/bound-local.vert               |  25 +
 .../compiler/images/bound-nonuniform.vert          |  23 +
 .../compiler/images/explicit-conversions.vert      |  86 ++++
 .../compiler/images/flat-input.frag                |  28 ++
 .../compiler/images/implicit_conversions.vert      |  22 +
 .../compiler/images/indexing.vert                  |  27 ++
 .../compiler/images/inout-struct.frag              |  29 ++
 .../compiler/images/inout.frag                     |  24 +
 .../compiler/images/input.frag                     |  28 ++
 .../compiler/images/input.vert                     |  25 +
 .../compiler/images/interface-block.vert           |  27 ++
 .../compiler/images/out-struct.frag                |  29 ++
 .../arb_bindless_texture/compiler/images/out.frag  |  24 +
 .../compiler/images/output.frag                    |  22 +
 .../compiler/images/output.vert                    |  24 +
 .../compiler/images/return-struct.frag             |  32 ++
 .../compiler/images/temporary.vert                 |  21 +
 .../compiler/samplers/arith-expr.vert              |  31 ++
 .../samplers/bindless-global-and-bound-global.vert |  25 +
 .../compiler/samplers/bindless-global.vert         |  24 +
 .../compiler/samplers/bindless-local.vert          |  24 +
 .../compiler/samplers/bindless-nonuniform.vert     |  22 +
 .../compiler/samplers/bound-global.vert            |  24 +
 .../compiler/samplers/bound-local.vert             |  24 +
 .../compiler/samplers/bound-nonuniform.vert        |  22 +
 .../compiler/samplers/explicit-conversions.vert    | 114 +++++
 .../compiler/samplers/flat-input.frag              |  27 ++
 .../compiler/samplers/implicit-conversions.vert    |  21 +
 .../compiler/samplers/indexing.vert                |  26 +
 .../compiler/samplers/inout-struct.frag            |  28 ++
 .../compiler/samplers/inout.frag                   |  23 +
 .../compiler/samplers/input.frag                   |  27 ++
 .../compiler/samplers/input.vert                   |  24 +
 .../compiler/samplers/interface-block.vert         |  26 +
 .../compiler/samplers/out-struct.frag              |  28 ++
 .../compiler/samplers/out.frag                     |  23 +
 .../compiler/samplers/output.frag                  |  21 +
 .../compiler/samplers/output.vert                  |  23 +
 .../compiler/samplers/return-struct.frag           |  31 ++
 .../compiler/samplers/temporary.vert               |  20 +
 tests/spec/arb_bindless_texture/conversions.c      | 371 +++++++++++++++
 tests/spec/arb_bindless_texture/errors.c           | 505 ++++++++++++++++++++
 .../basic-imageAtomicExchange.shader_test          |  39 ++
 .../execution/basic-imageStore.shader_test         |  43 ++
 .../execution/basic-texture2D.shader_test          |  26 +
 .../execution/image-input-output.shader_test       |  58 +++
 .../multiple-resident-images-reading.shader_test   |  84 ++++
 .../execution/sampler-input-output.shader_test     |  41 ++
 tests/spec/arb_bindless_texture/handles.c          | 521 +++++++++++++++++++++
 tests/spec/arb_bindless_texture/illegal.c          | 326 +++++++++++++
 tests/spec/arb_bindless_texture/legal.c            | 259 ++++++++++
 tests/spec/arb_bindless_texture/limit.c            | 304 ++++++++++++
 ...obal_bindless_image_and_bound_image.shader_test |  42 ++
 ...al_bindless_image_and_bound_sampler.shader_test |  32 ++
 ...bindless_sampler_and_bindless_image.shader_test |  32 ++
 ...al_bindless_sampler_and_bound_image.shader_test |  32 ++
 ..._bindless_sampler_and_bound_sampler.shader_test |  39 ++
 ...lobal_bound_sampler_and_bound_image.shader_test |  32 ++
 tests/spec/arb_bindless_texture/uint64_attribs.c   |  96 ++++
 tests/spec/arb_bindless_texture/uniform.c          | 365 +++++++++++++++
 74 files changed, 4979 insertions(+)
 create mode 100644 tests/spec/arb_bindless_texture/CMakeLists.gl.txt
 create mode 100644 tests/spec/arb_bindless_texture/CMakeLists.txt
 create mode 100644 tests/spec/arb_bindless_texture/border-color.c
 create mode 100644 tests/spec/arb_bindless_texture/common.c
 create mode 100644 tests/spec/arb_bindless_texture/common.h
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/arith-expr.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/bindless-global-and-bound-global.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/bindless-global.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/bindless-local.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/bindless-nonuniform.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/bound-global.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/bound-local.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/bound-nonuniform.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/explicit-conversions.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/flat-input.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/implicit_conversions.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/indexing.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/inout-struct.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/inout.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/input.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/input.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/interface-block.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/out-struct.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/out.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/output.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/output.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/return-struct.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/images/temporary.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/arith-expr.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/bindless-global-and-bound-global.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/bindless-global.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/bindless-local.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/bindless-nonuniform.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/bound-global.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/bound-local.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/bound-nonuniform.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/explicit-conversions.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/flat-input.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/implicit-conversions.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/indexing.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/inout-struct.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/inout.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/input.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/input.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/interface-block.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/out-struct.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/out.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/output.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/output.vert
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/return-struct.frag
 create mode 100644 tests/spec/arb_bindless_texture/compiler/samplers/temporary.vert
 create mode 100644 tests/spec/arb_bindless_texture/conversions.c
 create mode 100644 tests/spec/arb_bindless_texture/errors.c
 create mode 100644 tests/spec/arb_bindless_texture/execution/basic-imageAtomicExchange.shader_test
 create mode 100644 tests/spec/arb_bindless_texture/execution/basic-imageStore.shader_test
 create mode 100644 tests/spec/arb_bindless_texture/execution/basic-texture2D.shader_test
 create mode 100644 tests/spec/arb_bindless_texture/execution/image-input-output.shader_test
 create mode 100644 tests/spec/arb_bindless_texture/execution/multiple-resident-images-reading.shader_test
 create mode 100644 tests/spec/arb_bindless_texture/execution/sampler-input-output.shader_test
 create mode 100644 tests/spec/arb_bindless_texture/handles.c
 create mode 100644 tests/spec/arb_bindless_texture/illegal.c
 create mode 100644 tests/spec/arb_bindless_texture/legal.c
 create mode 100644 tests/spec/arb_bindless_texture/limit.c
 create mode 100644 tests/spec/arb_bindless_texture/linker/global_bindless_image_and_bound_image.shader_test
 create mode 100644 tests/spec/arb_bindless_texture/linker/global_bindless_image_and_bound_sampler.shader_test
 create mode 100644 tests/spec/arb_bindless_texture/linker/global_bindless_sampler_and_bindless_image.shader_test
 create mode 100644 tests/spec/arb_bindless_texture/linker/global_bindless_sampler_and_bound_image.shader_test
 create mode 100644 tests/spec/arb_bindless_texture/linker/global_bindless_sampler_and_bound_sampler.shader_test
 create mode 100644 tests/spec/arb_bindless_texture/linker/global_bound_sampler_and_bound_image.shader_test
 create mode 100644 tests/spec/arb_bindless_texture/uint64_attribs.c
 create mode 100644 tests/spec/arb_bindless_texture/uniform.c

-- 
2.12.2



More information about the Piglit mailing list