[Piglit] [PATCH] gl30basic: add some extra suspected extension

Tapani Pälli tapani.palli at intel.com
Tue Apr 25 11:18:19 UTC 2017



On 04/24/2017 07:47 PM, Sandra Koroniewska wrote:
> This fixes
> spec/gl30basic test on Intel or Nvidia driver according to page 693 of openGL 4.4 spec ("In additional to OpenGL extensions, there are also ARB extensions to the related GLX and WGL APIs.").

I tried with Nvidia driver on Linux (version 355.11) that lists 308 
extensions but all of them begin with 'GL_' (none with WGL or GLX) so it 
passes this test.

I believe GLX extensions are only to be queried with 
glXQueryExtensionsString but it seems WGL ones are valid for both 
glGetString and wglGetExtensionsStringARB. I'm not sure if this fix is 
correct .. just wanted to point out my test result.


> ---
>   tests/general/gl30basic.c | 12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/general/gl30basic.c b/tests/general/gl30basic.c
> index 2207787bb..509f80fca 100644
> --- a/tests/general/gl30basic.c
> +++ b/tests/general/gl30basic.c
> @@ -99,8 +99,16 @@ test_extension_list(void)
>             ext[0] != 'G' ||
>             ext[1] != 'L' ||
>             ext[2] != '_') {
> -         printf("%s: bad extension string [%d]: %s\n", Prog, k, ext);
> -         return PIGLIT_FAIL;
> +          if (ext[0] != 'W' ||
> +              ext[1] != 'G' ||
> +              ext[2] != 'L') {
> +              if (ext[0] != 'G' ||
> +                  ext[1] != 'L' ||
> +                  ext[2] != 'X') {
> +                  printf("%s: bad extension string [%d]: %s\n", Prog, k, ext);
> +                  return PIGLIT_FAIL;
> +              }
> +          }
>         }
>         if (strchr((char *) ext, ' ')) {
>            printf("%s: extension string [%d] contains a space: %s\n", Prog, k, ext);
> 


More information about the Piglit mailing list