[Piglit] [PATCH] gl30basic: add some extra suspected extension

[Dylan Baker]

I can't speak to the validity of the patch, however, I have a few comments.

Quoting Sandra Koroniewska (2017-04-24 09:47:39)
> This fixes
> spec/gl30basic test on Intel or Nvidia driver according to page 693 of openGL 4.4 spec ("In additional to OpenGL extensions, there are also ARB extensions to the related GLX and WGL APIs.").

Please be sure to specify that you mean "the Windows Intel driver" not the Linux
driver.

> ---
>  tests/general/gl30basic.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/general/gl30basic.c b/tests/general/gl30basic.c
> index 2207787bb..509f80fca 100644
> --- a/tests/general/gl30basic.c
> +++ b/tests/general/gl30basic.c
> @@ -99,8 +99,16 @@ test_extension_list(void)
>            ext[0] != 'G' ||
>            ext[1] != 'L' ||
>            ext[2] != '_') {
> -         printf("%s: bad extension string [%d]: %s\n", Prog, k, ext);
> -         return PIGLIT_FAIL;
> +          if (ext[0] != 'W' ||
> +              ext[1] != 'G' ||
> +              ext[2] != 'L') {
> +              if (ext[0] != 'G' ||
> +                  ext[1] != 'L' ||
> +                  ext[2] != 'X') {
> +                  printf("%s: bad extension string [%d]: %s\n", Prog, k, ext);
> +                  return PIGLIT_FAIL;
> +              }
> +          }

You likely want to #define this rather than testing both WGL and GLX, since only
one or the other is valid on a given platform.

>        }
>        if (strchr((char *) ext, ' ')) {
>           printf("%s: extension string [%d] contains a space: %s\n", Prog, k, ext);
> -- 
> 2.11.0.windows.1
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170425/cc94e440/attachment.sig>