[Piglit] [PATCH 1/6] arb_bindless_texture: test bound samplers/image with glUniform1i()

Samuel Pitoiset samuel.pitoiset at gmail.com
Wed Apr 26 22:52:31 UTC 2017


>From section 2.14.16 of the ARB_bindless_texture spec:

    "When used as uniforms in the default block, the value of sampler
     variables may be specified with either Uniform1i{v} or
     UniformHandleui64{v}ARB."

>From section 2.14.X of the ARB_bindless_texture spec:

    "When used as uniforms in the default block, the value of image
     variables may be specified with either Uniform1i{v} or
     UniformHandleui64{v}ARB."

This test just ensures that setting a uniform to bound samplers
doesn't report any GL errors.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 tests/spec/arb_bindless_texture/uniform.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/spec/arb_bindless_texture/uniform.c b/tests/spec/arb_bindless_texture/uniform.c
index c4c06df05..1524eb18c 100644
--- a/tests/spec/arb_bindless_texture/uniform.c
+++ b/tests/spec/arb_bindless_texture/uniform.c
@@ -158,6 +158,7 @@ check_UniformHandleui64_with_implicit_bound_sampler(void *data)
 	 */
 	glUniformHandleui64ARB(loc, handle);
 	glProgramUniformHandleui64vARB(prog, loc, 1, &handle);
+	glUniform1i(loc, 5);
 	if (!piglit_check_gl_error(GL_NO_ERROR))
 		return PIGLIT_FAIL;
 
@@ -223,6 +224,7 @@ check_UniformHandleui64_with_implicit_bound_image(void *data)
 	 */
 	glUniformHandleui64ARB(loc, handle);
 	glProgramUniformHandleui64vARB(prog, loc, 1, &handle);
+	glUniform1i(loc, 5);
 	if (!piglit_check_gl_error(GL_NO_ERROR))
 		return PIGLIT_FAIL;
 
-- 
2.12.2



More information about the Piglit mailing list