[Piglit] [PATCH] glean: remove line drawing code from fbo test

Eric Anholt eric at anholt.net
Fri Aug 4 19:08:10 UTC 2017

Brian Paul <brianp at vmware.com> writes:

> The glean fbo test exercises rendering to 1D, 2D, 3D and cube images
> attached to FBOs.  For the 1D texture case, the rendering is done with
> a line, rather than a polygon.  Since the 1D image is one pixel high,
> the slightest mis-rasterization of the line will cause it to be clipped
> and the test to fail.
> Just fall through to the polygon drawing code to avoid that issue.
> Less code too.

If you just remove the whole switch statement around the POLYGON drawing
code, this would get my r-b. :)

I like this.  Test line rasterization only in something that's about
lines -- they're tricky to test well, and we've had plenty of trouble
with this draw call.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170804/569c9024/attachment.sig>

More information about the Piglit mailing list