[Piglit] [PATCH] glean: remove line drawing code from fbo test

Brian Paul brianp at vmware.com
Tue Aug 15 23:08:49 UTC 2017

On 08/04/2017 01:08 PM, Eric Anholt wrote:
> Brian Paul <brianp at vmware.com> writes:
>> The glean fbo test exercises rendering to 1D, 2D, 3D and cube images
>> attached to FBOs.  For the 1D texture case, the rendering is done with
>> a line, rather than a polygon.  Since the 1D image is one pixel high,
>> the slightest mis-rasterization of the line will cause it to be clipped
>> and the test to fail.
>> Just fall through to the polygon drawing code to avoid that issue.
>> Less code too.
> If you just remove the whole switch statement around the POLYGON drawing
> code, this would get my r-b. :)
> I like this.  Test line rasterization only in something that's about
> lines -- they're tricky to test well, and we've had plenty of trouble
> with this draw call.

My patch was already pushed.  I'm posting a follow-up to do this clean-up.


More information about the Piglit mailing list