[Piglit] [PATCH 1/5] Rename gen_conversion_fp64 to gen_conversion

Nicolai Hähnle nhaehnle at gmail.com
Thu Feb 2 14:48:39 UTC 2017


On 01.02.2017 19:30, Dylan Baker wrote:
> Can you modify 'unittests/generators/test_generators.py' to know about the
> rename, and run the tests? 'pytest unittest/generators' or "tox -e
> 'py{27,35}-generators'" will run the tests, depending on what you have
> installed.

FWIW, there are some warnings that are surely unrelated:

WW0 in unittests/generators/test_generators.py:40 the following warning 
was recorded:
 
../../../../home/nha/amd/piglit/.tox/py27-generator/local/lib/python2.7/site-packages/_pytest/assertion/rewrite.py:74: 
ImportWarning: Not importing directory '/home/nha/amd/piglit/templates': 
missing __init__.py
   fd, fn, desc = imp.find_module(lastname, path)

WW0 in unittests/generators/test_generators.py:40 the following warning 
was recorded:
 
../../../../home/nha/amd/piglit/generated_tests/gen_builtin_packing_tests.py:45: 
ImportWarning: Not importing directory '/home/nha/amd/piglit/templates': 
missing __init__.py
   from templates import template_dir

Apart from that, it all looks green (in particular the py35-generator 
environment has no warnings).

> If that passes, for the series:
> Acked-by: Dylan Baker <dylan at pnwbakers.com>

Thanks!

Nicolai


More information about the Piglit mailing list