[Piglit] [PATCH] ARB_texture_multisample: Don't use a 3D texture size above the minmax.

[Eric Anholt]

Tapani Pälli <tapani.palli at intel.com> writes:

> On 12/29/2016 09:20 PM, Eric Anholt wrote:
>> For GL 3.1, the minmax is 256, and for GL 2.1 it's only 16.  We don't
>> put anything in the texture, so we can just use 16.
>
> could change that for all those 3 calls, with that:
>
> Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

I take this patch back.  It's obviously not doing things to 3D textures,
it's doing things to 2D array textures with the 3d entrypoint.  And my
driver shouldn't be exposing 2D array textures, so I need to go figure
out why we aren't throwing a bad enum for this target in the first
place.

>> ---
>>  tests/spec/arb_texture_multisample/teximage-3d-multisample.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/spec/arb_texture_multisample/teximage-3d-multisample.c b/tests/spec/arb_texture_multisample/teximage-3d-multisample.c
>> index dcbbbf4417bf..3de8f5fc29bb 100644
>> --- a/tests/spec/arb_texture_multisample/teximage-3d-multisample.c
>> +++ b/tests/spec/arb_texture_multisample/teximage-3d-multisample.c
>> @@ -54,7 +54,7 @@ piglit_init(int argc, char **argv)
>>  	/* Pass a Texture Multisample 3D Array */
>>  	glBindTexture(GL_TEXTURE_2D_MULTISAMPLE_ARRAY, textures[0]);
>>  	glTexImage3DMultisample(GL_TEXTURE_2D_MULTISAMPLE_ARRAY, 4, GL_RGB,
>> -				1024, 1024, 4, GL_FALSE);
>> +				16, 16, 4, GL_FALSE);
>>  	pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
>>
>>  	/* Pass a Proxy Texture 3D Multisample Array */
>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170103/f80bc33b/attachment.sig>