[Piglit] [PATCH] ARB_texture_multisample: Don't use a 3D texture size above the minmax.

Ilia Mirkin imirkin at alum.mit.edu
Tue Jan 3 19:06:37 UTC 2017

On Tue, Jan 3, 2017 at 1:55 PM, Eric Anholt <eric at anholt.net> wrote:
> Tapani Pälli <tapani.palli at intel.com> writes:
>> On 12/29/2016 09:20 PM, Eric Anholt wrote:
>>> For GL 3.1, the minmax is 256, and for GL 2.1 it's only 16.  We don't
>>> put anything in the texture, so we can just use 16.
>> could change that for all those 3 calls, with that:
>> Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
> I take this patch back.  It's obviously not doing things to 3D textures,
> it's doing things to 2D array textures with the 3d entrypoint.  And my
> driver shouldn't be exposing 2D array textures, so I need to go figure
> out why we aren't throwing a bad enum for this target in the first
> place.

Looks like texobj.c:texture_image_multisample only checks for
ARB_texture_multisample, not EXT_texture_array.


More information about the Piglit mailing list