[Piglit] [PATCH] arb_texture_multisample/sample-mask-execution: check GL_MAX_SAMPLES

Eric Anholt eric at anholt.net
Tue Jul 25 16:44:27 UTC 2017

Brian Paul <brianp at vmware.com> writes:

> Skip the test if GL_MAX_SAMPLES=0.  We basically do that test in most
> of the other MSAA tests.
> As is, we get a bunch of errors because we cannot create the MSAA FBO and
> then an unexpected GL_INVALID_OPERATION error generates a piglit failure.

You could only have this case if you're exposing
GL_ARB_texture_multisample and GL_ARB_framebuffer_object but not
GL_EXT_framebuffer_multisample, right?  Does it make any sense to be
exposing GL_ARB_texture_multisample without that?

That said, the specs seem to allow it, so:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170725/831c4630/attachment.sig>

More information about the Piglit mailing list