[Piglit] [PATCH 3/3] framework: improve var names, comments in console() function

Dylan Baker dylan at pnwbakers.com
Thu Oct 19 00:17:35 UTC 2017


Quoting Brian Paul (2017-10-16 12:49:43)
> ---
>  framework/summary/console_.py | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/framework/summary/console_.py b/framework/summary/console_.py
> index 3b58ba4..ee6cbd8 100644
> --- a/framework/summary/console_.py
> +++ b/framework/summary/console_.py
> @@ -105,10 +105,11 @@ def _print_result(results, list_):
>              statuses=' '.join(str(r) for r in results.get_result(test))))
>  
>  
> -def console(results, mode):
> -    """ Write summary information to the console """
> +def console(resultsFiles, mode):

Could we use pep8 style results_files instead of resultsFiles?

With that changed for the series:
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

> +    """ Write summary information to the console for the given list of
> +    results files in the given mode."""
>      assert mode in ['summary', 'diff', 'incomplete', 'all'], mode
> -    results = Results([backends.load(r) for r in results])
> +    results = Results([backends.load(r) for r in resultsFiles])
>  
>      # Print the name of the test and the status from each test run
>      if mode == 'all':
> -- 
> 1.9.1
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20171018/bad97386/attachment.sig>


More information about the Piglit mailing list