[Piglit] [PATCH 3/4] arb_internalformat_query2: fix TBO testing

Ilia Mirkin imirkin at alum.mit.edu
Sun Oct 22 15:21:25 UTC 2017

On Sun, Oct 22, 2017 at 6:33 AM, Alejandro Piñeiro <apinheiro at igalia.com> wrote:
> On 21/10/17 14:55, Marek Olšák wrote:
>> From: Marek Olšák <marek.olsak at amd.com>
>> This was never tested and it uses functions that are illegal with TBOs,
>> like glGetTexParameteriv and glTexImage2DMultisample.
> Hi, I didn't check all the patch in detail, but as Illia is saying, it
> is correct to pass TEXTURE_BUFFER to GetInternalFormat*. I also disagree
> that this case it is not tested, or at least for the case I checked. See
> below, I have two extra comments.

It's untested because these are all run in compat contexts, which in
turn don't have GL_TEXTURE_BUFFER support. [At least untested against
current mesa.]


More information about the Piglit mailing list