[Piglit] [PATCH 3/4] arb_internalformat_query2: fix TBO testing

Alejandro Piñeiro apinheiro at igalia.com
Sun Oct 22 17:55:33 UTC 2017

On 22/10/17 17:21, Ilia Mirkin wrote:
> On Sun, Oct 22, 2017 at 6:33 AM, Alejandro Piñeiro <apinheiro at igalia.com> wrote:
>> On 21/10/17 14:55, Marek Olšák wrote:
>>> From: Marek Olšák <marek.olsak at amd.com>
>>> This was never tested and it uses functions that are illegal with TBOs,
>>> like glGetTexParameteriv and glTexImage2DMultisample.
>> Hi, I didn't check all the patch in detail, but as Illia is saying, it
>> is correct to pass TEXTURE_BUFFER to GetInternalFormat*. I also disagree
>> that this case it is not tested, or at least for the case I checked. See
>> below, I have two extra comments.
> It's untested because these are all run in compat contexts, which in
> turn don't have GL_TEXTURE_BUFFER support. [At least untested against
> current mesa.]

Ah ok. In any case, somehow is still testing it, as in compat mode it
should return NONE, as you say, because on that case it doesn't support
TEXTURE_BUFFER (dependencies are checked).

In any case, as I said (you mentioned it before) the solution is not
test TBO, but as you said, fix the piglit tests to run in non compat
modes. Probably improve more than fix, in order to test both compat and
non compat modes.


More information about the Piglit mailing list