[Piglit] [Crucible] [PATCH 1/2] build: Do not overwrite user variables

Jason Ekstrand jason at jlekstrand.net
Wed Sep 13 16:30:57 UTC 2017


Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Sat, Sep 9, 2017 at 12:15 PM, Józef Kucia <joseph.kucia at gmail.com> wrote:

> Allows passing CPPFLAGS, CFLAGS and CXXFLAGS to configure.
> ---
>
> I am not sure if this is the best place to submit patches for Crucible.
>
> ---
>  Makefile.am | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 656ee22..0478868 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -21,7 +21,7 @@
>
>  export CRUCIBLE_TOP := $(srcdir)
>
> -CPPFLAGS = \
> +AM_CPPFLAGS = \
>     $(MESA_CPPFLAGS) \
>     -D_DEFAULT_SOURCE \
>     -D_GNU_SOURCE \
> @@ -37,13 +37,13 @@ common_CFLAGS = -Wall -O0 -g3 \
>         $(LIBXML2_CFLAGS) \
>         $(NULL)
>
> -CFLAGS = -std=gnu11 \
> +AM_CFLAGS = -std=gnu11 \
>          $(common_CFLAGS) \
>         -Werror=implicit-function-declaration \
>         -Werror=implicit-int \
>         -Werror=missing-prototypes
>
> -CXXFLAGS = -std=c++11 $(common_CFLAGS)
> +AM_CXXFLAGS = -std=c++11 $(common_CFLAGS)
>
>  noinst_PROGRAMS = \
>         bin/crucible
> --
> 2.13.5
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20170913/f873545a/attachment.html>


More information about the Piglit mailing list