[Piglit] [Crucible] [PATCH 2/2] qonos: Create empty layouts for graphics pipelines

Józef Kucia joseph.kucia at gmail.com
Sat Sep 16 12:34:32 UTC 2017


On Sat, Sep 9, 2017 at 9:15 PM, Józef Kucia <joseph.kucia at gmail.com> wrote:
> The layout must be a valid VkPipelineLayout handle.
> ---
>  src/qonos/qonos_pipeline.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/qonos/qonos_pipeline.c b/src/qonos/qonos_pipeline.c
> index c95a937..f7600a4 100644
> --- a/src/qonos/qonos_pipeline.c
> +++ b/src/qonos/qonos_pipeline.c
> @@ -264,6 +264,9 @@ qoCreateGraphicsPipeline(VkDevice device,
>              };
>      }
>
> +    if (!pipeline_info.layout)
> +        pipeline_info.layout = qoCreatePipelineLayout(device);
> +
>      result = vkCreateGraphicsPipelines(device, pipeline_cache,
>                                         1, &pipeline_info, NULL, &pipeline);
>
> --

This fixes some validation errors in a few tests. It is invalid to use
VK_NULL_HANDLE as the pipeline layout. An empty pipeline layout is
what we want to use when shaders do not need push constants and
descriptors.

I do not have commit access. If someone review this change, please
push the series for me.


More information about the Piglit mailing list