[Piglit] [Bug 106052] shader-db crashes when running piglit shaders

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Apr 17 23:11:41 UTC 2018


--- Comment #25 from Timothy Arceri <t_arceri at yahoo.com.au> ---
(In reply to ben at besd.de from comment #20)
> All it takes is
> -   if (consts->GLSLVersion >= 400)
> +   if (consts->GLSLVersion >= 150)
>        extensions->ARB_gpu_shader5 = GL_TRUE;
> and everything is fine (well not everything but that is ;)

The decision to use GLSL 4.00 seems to have been made because of the complex
interactions of the spec:

commit 6f1edf3cbf0ce4cb8e95f2d8bd68c9c26d3f840c
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date:   Sat Aug 9 20:00:20 2014 -0400

    mesa/st: enable ARB_gpu_shader5 if the reported GLSL version >= 400

    The ARB_gpu_shader5 extension is made up of a lot of small sub-parts.
    Instead of adding PIPE_CAP's for each of these, just rely on the GLSL
    version reported by the pipe driver. The remaining extensions lend
    themselves naturally to being checked through a single CAP.

    Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
    Reviewed-by: Marek Olšák <marek.olsak at amd.com>

You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20180417/64d967ad/attachment.html>

More information about the Piglit mailing list