[Piglit] [PATCH] arb_gl_spirv: add test for uniform blocks with the same structure

[apinheiro]

On 23/11/18 19:41, Józef Kucia wrote:
> On Thu, Nov 22, 2018 at 11:21 AM apinheiro <apinheiro at igalia.com> wrote:
>> some weeks ago I sent a series with ubo/ssbo tests (still pending review)
>>
>> https://lists.freedesktop.org/archives/piglit/2018-September/025116.html
>>
>> All those has the name stripped. Could you try them and see if any of
>> them triggers the NVIDIA bug you found?
> arb_gl_spirv @ execution @ ubo @ matrix @ column-vs-row.shader_test
> triggers the NVIDIA bug.


Then do you think that your test is still needed? An alternative, as we
didn't add any compute shader using ubo/ssbo, would be rename and update
the description of your test (something like "compute shader using ubo").

Also if you are interested to get those tests integrated, you can just
take a look an review them, wink wink


>
> BTW, where can I find the "shader_test_spirv.py" script?


You can find it on our WIP (so several wip and fixme patches)
ARB_gl_spirv piglit branch:

https://github.com/Igalia/piglit/tree/igalia/arb_gl_spirv

On the directory generated_spv

We didn't send it to review yet because it needs a lot of cleaning and
squashing. We will do that eventually, but we are focus first on getting
ARB_gl_spirv finished.


>
> Thanks,
> Józef
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pEpkey.asc
Type: application/pgp-keys
Size: 1546 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20181124/ab7fb549/attachment.key>