[Piglit] [Bug 108612] The spec at arb_program_interface_query@arb_program_interface_query-getprogramresourceiv fails

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108612

Tapani Pälli <lemody at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Tapani Pälli <lemody at gmail.com> ---
Fixed!

--- 8< ---
commit a96854e3406be69abca77e1e9ce63720e7a3c985
Author: Andrii Simiklit <andrii.simiklit at globallogic.com>
Date:   Wed Oct 31 17:05:56 2018 +0200

    program_interface_query: don't expect a valid location for TCS output

    I guess we should not expect a valid location for:
    "patch out vec4 tcs_patch;"
    because this output variable is declareted
    without "layout (location=X)" and according to spec:
       "Not all active variables are assigned valid locations; the
        following variables will have an effective location of -1:

          * uniforms declared as atomic counters;

          * members of a uniform block;

          * built-in inputs, outputs, and uniforms (starting with "gl_"); and

          * inputs or outputs not declared with a "location" layout qualifier,
            except for vertex shader inputs and fragment shader outputs."

    Also I fixed some conflicting comments.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108612
    Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
    Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20181129/2966b632/attachment-0001.html>