[Piglit] [PATCH v2 1/6] texturing: make sure s3tc tests require GL 1.1

[Erik Faye-Lund]

On Fri, 2018-10-26 at 16:21 +0100, Emil Velikov wrote:
> On Fri, 26 Oct 2018 at 14:03, Erik Faye-Lund
> <erik.faye-lund at collabora.com> wrote:
> > 
> > The EXT_texture_compression_s3tc spec lists that it requires
> > OpenGL 1.1, not 1.0 like some of these list.
> > 
> > In reality, this probably doesn't make a huge difference, as
> > OpenGL 1.0 hardware/drivers are pretty much extinct, but let's
> > just get it right to avoid confusion.
> > 
> > Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
> > ---
> >  tests/texturing/s3tc-errors.c      | 2 +-
> >  tests/texturing/s3tc-teximage.c    | 2 +-
> >  tests/texturing/s3tc-texsubimage.c | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tests/texturing/s3tc-errors.c b/tests/texturing/s3tc-
> > errors.c
> > index 81fee3e21..ccedf8a22 100644
> > --- a/tests/texturing/s3tc-errors.c
> > +++ b/tests/texturing/s3tc-errors.c
> > @@ -36,7 +36,7 @@
> > 
> >  PIGLIT_GL_TEST_CONFIG_BEGIN
> > 
> > -    config.supports_gl_compat_version = 10;
> > +    config.supports_gl_compat_version = 11;
> > 
> 
> Ages ago Ilia reported on IRC that some tests (was it 10 or 11, don't
> recall) failing on the classic swrast and/or nouveau_vieux.
> That waffle issue should be fixed, although if he can give this patch
> a try (with platform glx) that'll be appreciated ...
> 
> Gut feeling suggests that the fix may not have been enough.

I don't think I understand the issue... Some of these tests use 10 and
some use 11 here, and 11 is the correct value (according to the spec).
I'm just making it consistent...

This is just a filter under what contexts these tests will run, no? I
haven't seen an OpenGL 1.0-only implementation, well, ever I think?
Isn't this just theoretical anyway? I don't understand how this could
have any practical effect...