[Piglit] [PATCH] EXT_shader_image_load_store: skip atomics for not-1x32 types

Ilia Mirkin imirkin at alum.mit.edu
Wed Aug 7 00:33:23 UTC 2019


>From the spec:

    The format of the image unit must be in the "1x32" equivalence class
    in Table X.2 in Section 3.9.X of the OpenGL specification, otherwise
    the atomic operation is invalid.

So we skip these.

Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
---
 tests/spec/ext_shader_image_load_store/image_functions.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/spec/ext_shader_image_load_store/image_functions.c b/tests/spec/ext_shader_image_load_store/image_functions.c
index 7b37a6982..22a3dfc72 100644
--- a/tests/spec/ext_shader_image_load_store/image_functions.c
+++ b/tests/spec/ext_shader_image_load_store/image_functions.c
@@ -236,6 +236,10 @@ run_compile_test(void * data)
 				if (atomicOp && floatImageType)
 					continue;
 
+				/* skip atomic + not-1x32 */
+				if (atomicOp && i != 2)
+					continue;
+
 				/* Build the fragment template */
 				sprintf(fs, fs_template,
 					v_value_type[k % 3],
-- 
2.21.0



More information about the Piglit mailing list