[Piglit] [PATCH] EXT_shader_image_load_store: skip atomics for not-1x32 types

Pelloux-prayer, Pierre-eric Pierre-eric.Pelloux-prayer at amd.com
Wed Aug 7 09:12:37 UTC 2019


Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>

On 07/08/2019 02:33, Ilia Mirkin wrote:
> From the spec:
> 
>     The format of the image unit must be in the "1x32" equivalence class
>     in Table X.2 in Section 3.9.X of the OpenGL specification, otherwise
>     the atomic operation is invalid.
> 
> So we skip these.
> 
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  tests/spec/ext_shader_image_load_store/image_functions.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/spec/ext_shader_image_load_store/image_functions.c b/tests/spec/ext_shader_image_load_store/image_functions.c
> index 7b37a6982..22a3dfc72 100644
> --- a/tests/spec/ext_shader_image_load_store/image_functions.c
> +++ b/tests/spec/ext_shader_image_load_store/image_functions.c
> @@ -236,6 +236,10 @@ run_compile_test(void * data)
>  				if (atomicOp && floatImageType)
>  					continue;
>  
> +				/* skip atomic + not-1x32 */
> +				if (atomicOp && i != 2)
> +					continue;
> +
>  				/* Build the fragment template */
>  				sprintf(fs, fs_template,
>  					v_value_type[k % 3],
> 


More information about the Piglit mailing list