[Piglit] [PATCH] editorconfig: Add max_line_length property

apinheiro apinheiro at igalia.com
Fri Feb 22 16:25:27 UTC 2019


On 22/2/19 15:51, Andres Gomez wrote:
> The property is supported by most of the editors, but not all:
> https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length
>
> Cc: Eric Engestrom <eric at engestrom.ch>
> Cc: Eric Anholt <eric at anholt.net>
> Signed-off-by: Andres Gomez <agomez at igalia.com>


It is really realistic to set 79 as max_line_length for piglit? Although 
on mesa that limit is usually well respected, I found several source 
files on piglit that are really loose on that limit, and Im not sure it 
was considered as an error/problem.


> ---
>   .editorconfig | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/.editorconfig b/.editorconfig
> index c614fcca7..e0f13a949 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -4,15 +4,19 @@ root = true
>   indent_style = space
>   indent_size = 4
>   trim_trailing_whitespace = true
> +max_line_length = 79
>   
>   [*.{c,cpp,h,hpp}]
>   indent_style = tab
>   tab_width = 8
> +max_line_length = 78
>   
>   [*.{cmake,txt}]
>   indent_style = tab
>   tab_width = 8
> +max_line_length = 78
>   
>   [{README,HACKING}]
>   indent_style = tab
>   tab_width = 8
> +max_line_length = 78


More information about the Piglit mailing list