[Piglit] [PATCH] editorconfig: Add max_line_length property

Ian Romanick idr at freedesktop.org
Fri Feb 22 20:03:36 UTC 2019


On 2/22/19 8:25 AM, apinheiro wrote:
> 
> On 22/2/19 15:51, Andres Gomez wrote:
>> The property is supported by most of the editors, but not all:
>> https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length
>>
>>
>> Cc: Eric Engestrom <eric at engestrom.ch>
>> Cc: Eric Anholt <eric at anholt.net>
>> Signed-off-by: Andres Gomez <agomez at igalia.com>
> 
> It is really realistic to set 79 as max_line_length for piglit? Although
> on mesa that limit is usually well respected, I found several source
> files on piglit that are really loose on that limit, and Im not sure it
> was considered as an error/problem.

A lot of patches land in piglit unreviewed. ;)  I prefer lines < 80, but
there's always room for exceptions.

>> ---
>>   .editorconfig | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/.editorconfig b/.editorconfig
>> index c614fcca7..e0f13a949 100644
>> --- a/.editorconfig
>> +++ b/.editorconfig
>> @@ -4,15 +4,19 @@ root = true
>>   indent_style = space
>>   indent_size = 4
>>   trim_trailing_whitespace = true
>> +max_line_length = 79
>>     [*.{c,cpp,h,hpp}]
>>   indent_style = tab
>>   tab_width = 8
>> +max_line_length = 78
>>     [*.{cmake,txt}]
>>   indent_style = tab
>>   tab_width = 8
>> +max_line_length = 78
>>     [{README,HACKING}]
>>   indent_style = tab
>>   tab_width = 8
>> +max_line_length = 78
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
> 



More information about the Piglit mailing list