[Pixman] [PATCH] Use windows.h directly for mingw32 build

Maarten Bosmans mkbosmans at gmail.com
Mon Aug 30 02:03:28 PDT 2010


2010/8/30 Soeren Sandmann <sandmann at daimi.au.dk>:
> Maarten Bosmans <mkbosmans at gmail.com> writes:
>
>> This patch adresses the issue discussed in
>> http://lists.freedesktop.org/archives/pixman/2010-April/000163.html
>>
>> There were only two clashing identifiers.  The first one is IN, which
>> obviously causes problems in Pixman for lines like
>>     PIXMAN_STD_FAST_PATH (IN, solid, a8, a8, fast_composite_in_n_8_8),
>> Fortunately the mingw headers provide a solution: by defining
>> _NO_W32_PSEUDO_MODIFIERS, these stupid symbols are skipped.
>>
>> The other name is UINT64, used in pixman-mmx.c. I renamed that
>> function to to_uint64, but may be another name is more appropriate. It
>> may also be good to rename the other function M64 to to_m64, but I
>> left that one alone for now.
>
> I do think M64 should be renamed to to_m64() for consistency, but
> other than that, the patch looks good to me.

Here you go, a new patch

> Soren
>

Maarten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-windows.h-directly-for-mingw32-build.patch
Type: application/octet-stream
Size: 10146 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/pixman/attachments/20100830/2c53aa9a/attachment.obj>


More information about the Pixman mailing list