[Pixman] [Patch] pixman comment typos
sandmann at cs.au.dk
Mon May 9 04:02:33 PDT 2011
Nis Martensen <nis.martensen at web.de> writes:
> Hi pixman developers,
> Please review and apply (if correct)!
The fixes look mostly correct to me, but we do need a more comprehensive
commit message than just "typos?"
> --- a/pixman/pixman-combine.c.template
> +++ b/pixman/pixman-combine.c.template
> @@ -437,7 +437,7 @@ combine_saturate_u (pixman_implementation_t *imp,
> * PDF_NON_SEPARABLE_BLEND_MODE macros, which take the blend function as an
> * argument. Note that this implementation operates on premultiplied colors,
> * while the PDF specification does not. Therefore the code uses the formula
> - * ar.Cra = (1 – as) . Dca + (1 – ad) . Sca + B(Dca, ad, Sca, as)
> + * ar.Cr = (1 – as) . Dca + (1 – ad) . Sca + B(Dca, ad, Sca, as)
This fix does make the formula correct, but it was intended to show how
to operate on premultiplied colors, so I think it would be better to
delete the "ar." rather than the "a" from "Cra".
More information about the Pixman