[Pixman] [Patch] pixman comment typos
Nis Martensen
nis.martensen at web.de
Mon May 9 12:06:59 PDT 2011
2011/5/9 Soeren Sandmann <sandmann at cs.au.dk>:
> The fixes look mostly correct to me, but we do need a more comprehensive
> commit message than just "typos?"
Thanks. Updated patch attached.
Regards,
Nis
-------------- next part --------------
From 2e219238a20e5b633b3554fb102c9fa4fb908e1a Mon Sep 17 00:00:00 2001
From: Nis Martensen <nis.martensen at web.de>
Date: Mon, 2 May 2011 21:43:58 +0200
Subject: [PATCH] Fix a few typos in pixman-combine.c.template
Some equations have too much multiplication with alpha.
---
pixman/pixman-combine.c.template | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/pixman/pixman-combine.c.template b/pixman/pixman-combine.c.template
index f5dd8e1..806a184 100644
--- a/pixman/pixman-combine.c.template
+++ b/pixman/pixman-combine.c.template
@@ -437,7 +437,7 @@ combine_saturate_u (pixman_implementation_t *imp,
* PDF_NON_SEPARABLE_BLEND_MODE macros, which take the blend function as an
* argument. Note that this implementation operates on premultiplied colors,
* while the PDF specification does not. Therefore the code uses the formula
- * ar.Cra = (1 ? as) . Dca + (1 ? ad) . Sca + B(Dca, ad, Sca, as)
+ * Cra = (1 ? as) . Dca + (1 ? ad) . Sca + B(Dca, ad, Sca, as)
*/
/*
@@ -849,7 +849,7 @@ PDF_SEPARABLE_BLEND_MODE (exclusion)
*
* r * set_sat (C, s) = set_sat (x * C, r * s)
*
- * The above holds for all non-zero x, because they x'es in the fraction for
+ * The above holds for all non-zero x, because the x'es in the fraction for
* C_mid cancel out. Specifically, it holds for x = r:
*
* r * set_sat (C, s) = set_sat (r_c, rs)
@@ -885,8 +885,7 @@ PDF_SEPARABLE_BLEND_MODE (exclusion)
*
* a_s * a_d * B(s, d)
* = a_s * a_d * set_lum (set_sat (S/a_s, SAT (D/a_d)), LUM (D/a_d), 1)
- * = a_s * a_d * set_lum (set_sat (a_d * S, a_s * SAT (D)),
- * a_s * LUM (D), a_s * a_d)
+ * = set_lum (set_sat (a_d * S, a_s * SAT (D)), a_s * LUM (D), a_s * a_d)
*
*/
--
1.7.2.5
More information about the Pixman
mailing list