[Pixman] [PATCH v4 2/2] mmx: Use _mm_shuffle_pi16

Matt Turner mattst88 at gmail.com
Tue Feb 21 09:44:26 PST 2012


On Tue, Feb 21, 2012 at 12:24 PM, Søren Sandmann <sandmann at cs.au.dk> wrote:
> Matt Turner <mattst88 at gmail.com> writes:
>
>> v4: use inline assembly since the intrinsic needs SSE or 3DNowA
>>       - we can't use -msse, since it'll cause more SSE instructions to be
>>         generated that we don't want
>>       - there is no -m3dnowa flag (anymore?)
>
> Both patches look good to me. Just one nitpick: with the use of pshufw,
> the data fields used in invert_colors() can be removed.
>
>
> Soren

Ah, yes. Thanks for pointing that out. I'll fix that up and commit.

Thanks :)
Matt


More information about the Pixman mailing list