[Pixman] 'SIZE_MAX' undeclared on Solaris 9 without including <limits.h>, sqrtf() missing

[Mojca Miklavec]

On Tue, Apr 2, 2013 at 12:49 PM, Søren Sandmann wrote:
> Mojca Miklavec writes:
>
>> We are using pixman in TeX (TeX Live) and on Solaris there are two
>> tiny problems that prevent compilation on Solaris 9:
>>
>> 1.) ../../../source/libs/pixman/pixman-0.28.0/pixman/pixman-utils.c:36:17:
>>  error: 'SIZE_MAX' undeclared (first use in this function)
>
> The SIZE_MAX issue is fixed in master already I believe.

Thank you very much and I'm sorry that I wasn't aware of it. I tested
it and it seems to work fine.

>> 2.) "sqrtf" function is missing, see also:
>>
>> http://www.gnu.org/software/gnulib/manual/html_node/sqrtf.html
>> http://www.winehq.org/pipermail/wine-patches/2003-February/005427.html
>>
>> One can use double sqrt(...) instead, but again, I'm not sure what the
>> best patch should be.
>
> Can't you just check for it in configure and if it doesn't exist, define
> a macro in pixman-compiler.h that defines it to sqrt?

The attached patch works on Solaris 9, but I'm not sure if this is the
right approach and most probably some math header and math flag is
missing somewhere next to AC_CHECK_FUNC(sqrtf...). I'm not sure how to
properly add that.

> Søren

PS: here are some more warnings in case that any of them is relevant
(probably not):

utils.c: In function 'fence_malloc':
utils.c:364:10: warning: pointer targets in assignment differ in
signedness [-Wpointer-sign]
utils.c:384:5: warning: pointer targets in passing argument 1 of
'mprotect' differ in signedness [-Wpointer-sign]
/opt/csw/lib/gcc/sparc-sun-solaris2.9/4.6.3/include-fixed/sys/mman.h:169:12:
note: expected 'caddr_t' but argument is of type 'uint8_t *'
utils.c:386:5: warning: pointer targets in passing argument 1 of
'mprotect' differ in signedness [-Wpointer-sign]
/opt/csw/lib/gcc/sparc-sun-solaris2.9/4.6.3/include-fixed/sys/mman.h:169:12:
note: expected 'caddr_t' but argument is of type 'uint8_t *'
utils.c:388:2: warning: pointer targets in passing argument 1 of
'munmap' differ in signedness [-Wpointer-sign]
/opt/csw/lib/gcc/sparc-sun-solaris2.9/4.6.3/include-fixed/sys/mman.h:168:12:
note: expected 'caddr_t' but argument is of type 'uint8_t *'
pixel-test.c: In function 'main':
pixel-test.c:199:31: warning: 'result' may be used uninitialized in
this function [-Wuninitialized]
pixel-test.c:138:14: note: 'result' was declared here
alphamap.c: In function 'get_alpha':
alphamap.c:58:13: warning: 'r' may be used uninitialized in this
function [-Wuninitialized]
alphamap.c: In function 'get_red.isra.0':
alphamap.c:141:5: warning: 'r' may be used uninitialized in this
function [-Wuninitialized]
matrix-test.c: In function 'test_matrix':
matrix-test.c:84:33: warning: variable 'transform_ok' set but not used
[-Wunused-but-set-variable]
lowlevel-blt-bench.c: In function 'bench_L':
lowlevel-blt-bench.c:182:18: warning: variable 'qx' set but not used
[-Wunused-but-set-variable]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sqrtf.patch
Type: application/octet-stream
Size: 964 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/pixman/attachments/20130404/23b107db/attachment.obj>