[Pixman] 'SIZE_MAX' undeclared on Solaris 9 without including <limits.h>, sqrtf() missing

[Søren Sandmann]

Mojca Miklavec <mojca.miklavec.lists at gmail.com> writes:

>>> 2.) "sqrtf" function is missing, see also:
>>>
>>> http://www.gnu.org/software/gnulib/manual/html_node/sqrtf.html
>>> http://www.winehq.org/pipermail/wine-patches/2003-February/005427.html
>>>
>>> One can use double sqrt(...) instead, but again, I'm not sure what the
>>> best patch should be.
>>
>> Can't you just check for it in configure and if it doesn't exist, define
>> a macro in pixman-compiler.h that defines it to sqrt?
>
> The attached patch works on Solaris 9, but I'm not sure if this is the
> right approach and most probably some math header and math flag is
> missing somewhere next to AC_CHECK_FUNC(sqrtf...). I'm not sure how to
> properly add that.

Right, that patch fails to find sqrtf on Linux. Using AC_CHECK_LIB with
the math library is probably good enough. Also, in order to have the
patch pushed, you will need to send it with a commit message generated
by git format-patch.


Soren