[Pixman] [PATCH 2/5] vmx: adjust macros when loading vectors on ppc64le

[Pekka Paalanen]

On Thu, 25 Jun 2015 14:41:37 +0300
Oded Gabbay <oded.gabbay at gmail.com> wrote:

> On Thu, Jun 25, 2015 at 2:05 PM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > On Tue, 16 Jun 2015 18:27:59 +0300
> > Oded Gabbay <oded.gabbay at gmail.com> wrote:
> >
> >> From: Fernando Seiti Furusato <ferseiti at linux.vnet.ibm.com>
> >>
> >> Replaced usage of vec_lvsl to direct unaligned assignment
> >> operation (=). That is because, according to Power ABI Specification,
> >> the usage of lvsl is deprecated on ppc64le.
> >>
> >> Changed COMPUTE_SHIFT_{MASK,MASKS,MASKC} macro usage to no-op for powerpc
> >> little endian since unaligned access is supported on ppc64le.
> >>
> >> Signed-off-by: Fernando Seiti Furusato <ferseiti at linux.vnet.ibm.com>
> >> ---
> >>  pixman/pixman-vmx.c | 54 ++++++++++++++++++++++++++++++++++++++---------------
> >>  1 file changed, 39 insertions(+), 15 deletions(-)
> >>
> >> diff --git a/pixman/pixman-vmx.c b/pixman/pixman-vmx.c
> >> index 23537f6..7e5eca7 100644
> >> --- a/pixman/pixman-vmx.c
> >> +++ b/pixman/pixman-vmx.c

> > Looks like you also modified Fernando's original patch, yet your name
> > is nowhere to be seen. It's common courtesy to note what you changed.
> >
> I think I only took part of his patch, and that part I did *not*
> modify, but I will double check it, and if I indeed modified
> something, I will comment about it.
> btw, I wrote a comment about it in the cover letter.

Cover letters do not go into git history. "Credit where credit is due",
in both good and bad, and if someone is digging for "blame", then he
looks in the git history. That's why we do commit messages like:

blah blah

S-o-b: A. Author
[B: frobbed the bar]
S-o-b: B. Author

It's more of a "netiquette" thing, I believe. Also, Fernando's patch
did not include the whitespace damage, you added that, so it's not nice
to account that to him. ;-)

> > The above were the comments that finally made me not just push this
> > series.
> Not sure I understood this sentence. Could you please elaborate ?

Just referring to my review comments about whitespace.


Thanks,
pq