[Pixman] [PATCH v13 04/14] pixman-image: Added enable-gnuplot config to view filters in gnuplot

[Søren Sandmann]

On Wed, Feb 10, 2016 at 1:25 AM, <spitzak at gmail.com> wrote:

> From: Bill Spitzak <spitzak at gmail.com>
>
> If enable-gnuplot is configured, then you can pipe the output of a
> pixman-using program
> to gnuplot and get a continuously-updated plot of the horizontal filter.
> This
> works well with demos/scale to test the filter generation.
>
> The plot is all the different subposition filters shuffled together. This
> is
> misleading in a few cases:
>
>   IMPULSE.BOX - goes up and down as the subfilters have different numbers
> of non-zero samples
>   IMPULSE.TRIANGLE - somewhat crooked for the same reason
>   1-wide filters - looks triangular, but a 1-wide box would be more
> accurate
>
> v7: First time this ability was included
>
> v8: Use config option
>     Moved code to the filter generator
>     Modified scale demo to not call filter generator a second time.
>
> v10: Only print if successful generation of plots
>      Use #ifdef, not #if
>
> v11: small whitespace fixes
>
> Signed-off-by: Bill Spitzak <spitzak at gmail.com>
> Reviewed-by: Oded Gabbay <oded.gabbay at gmail.com>
>

This is an interesting idea. It may be worth having it compiled in at all
times, but disabled unless a PIXMAN_GNUPLOT environment variable is set.

There is one formatting issue with this patch: Pixman coding style requires
a space before parentheses in function calls.


Søren
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pixman/attachments/20160304/a6a69a5f/attachment.html>