[Pixman] [PATCH v13 05/14] pixman-filter: Consistency in arg names to integral ()

Søren Sandmann soren.sandmann at gmail.com
Fri Mar 4 22:51:42 UTC 2016


On Wed, Feb 10, 2016 at 1:25 AM, <spitzak at gmail.com> wrote:

> From: Bill Spitzak <spitzak at gmail.com>
>
> Rename kernel1/2 to reconstruct/sample to match the other functions.
> Rename "scale" to "size" to avoid confusion with the scale being applied
> to the image, which is the reciprocol of this value.
>
> v10: Renamed "scale" to "size"
>

I don't really agree with this patch. The intention behind the code was
that the integral() function shouldn't know anything about scaling or
images; all it would do was compute integrals over functions, but it
wouldn't know or care what those functions were used for.


Søren
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pixman/attachments/20160304/e082e39d/attachment.html>


More information about the Pixman mailing list