[Pixman] [PATCH v13 06/14] pixman-filter: reduce amount of malloc/free/memcpy to generate filter

[Søren Sandmann]

On Wed, Feb 10, 2016 at 1:25 AM, <spitzak at gmail.com> wrote:

> From: Bill Spitzak <spitzak at gmail.com>
>
> Rearranged so that the entire block of memory for the filter pair
> is allocated first, and then filled in. Previous version allocated
> and freed two temporary buffers for each filter and did an extra
> memcpy.
>
> v8: small refactor to remove the filter_width function
>
> v10: Restored filter_width function but with arguments changed to
>      match later patches
>
> v11: Removed unused arg and pointer from filter_width function
>      Whitespace fixes.
>
> Signed-off-by: Bill Spitzak <spitzak at gmail.com>
> Reviewed-by: Oded Gabbay <oded.gabbay at gmail.com>
>

I'm not opposed to this patch if it is correct (and I'll believe the
existing Reviewed-by for correctness), but I'm also don't think there is
much point to this -- these malloc() and free() calls are unlikely to be
performance bottlenecks.

Acked-by: Soren Sandmann <soren.sandmann at gmail.com>


Søren
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pixman/attachments/20160304/d5bcb1b9/attachment.html>