[Pixman] [PATCH v13 05/14] pixman-filter: Consistency in arg names to integral ()

Bill Spitzak spitzak at gmail.com
Sat Mar 5 02:33:07 UTC 2016

On Fri, Mar 4, 2016 at 2:51 PM, Søren Sandmann <soren.sandmann at gmail.com>

> On Wed, Feb 10, 2016 at 1:25 AM, <spitzak at gmail.com> wrote:
>> From: Bill Spitzak <spitzak at gmail.com>
>> Rename kernel1/2 to reconstruct/sample to match the other functions.
>> Rename "scale" to "size" to avoid confusion with the scale being applied
>> to the image, which is the reciprocol of this value.
>> v10: Renamed "scale" to "size"
> I don't really agree with this patch. The intention behind the code was
> that the integral() function shouldn't know anything about scaling or
> images; all it would do was compute integrals over functions, but it
> wouldn't know or care what those functions were used for.

Okay will keep the arguments as before. In fact "scale" is used as expected
in the old version of the code (larger numbers mean the picture is being
enlarged). I still think renaming kernel1/2 to be the same name used in
other functions makes things a lot easier to follow.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pixman/attachments/20160304/b5f74295/attachment.html>

More information about the Pixman mailing list