[PATCH] Logging to file

Tollef Fog Heen tfheen at err.no
Wed Jan 16 13:54:58 PST 2008

* Juuso Alasuutari 

| Good catches. Thanks a lot!
| Here's a patch with the suggested changes:

A couple of comments:

 * Please get rid of all the ifdefs, they end up being annoying and I
   don't see a reason for anybody to not have them.

 * You seem to do an awful lot of logging, are you sure it's not
   better to just log the pkg-config invocation, including relevant
   environment variables?

 * Use proper functions rather than defines; I'd much rather have
   pkg-config work correctly than save five CPU cycles.

If you fix those things, I think I'll be happy to merge your patch.

Tollef Fog Heen
UNIX is user friendly, it's just picky about who its friends are

More information about the pkg-config mailing list