[PATCH 2/2] [scripts] Don't hardcode LIBEXECDIR and DATADIR paths

Ray Strode halfline at gmail.com
Tue Mar 2 12:14:07 PST 2010


Hi,

> The other option would be to define those as PLYMOUTH_LIBEXEC_DIR
> instead with something like this in configure.ac:
>
>        AS_AC_EXPAND(PLYMOUTH_LIBEXEC_DIR, $libexecdir)

So the original method is adding a line to the Makefile for every
variable, this one is adding a line to configure.ac for every
variable.  AS_AC_EXPAND doesn't seem like an obvious win to me over
the original way.

Having said that, I don't have a strong opinion in favor of any of the
three possible ways.  If you do have a less indifferent opinion about
it, feel free to commit one of your proposed changes (the other
changes in the patch are fine too).

--Ray


More information about the plymouth mailing list