[PATCH 2/2] [scripts] Don't hardcode LIBEXECDIR and DATADIR paths

[Scott James Remnant]

On Tue, 2010-03-02 at 15:14 -0500, Ray Strode wrote:

> > The other option would be to define those as PLYMOUTH_LIBEXEC_DIR
> > instead with something like this in configure.ac:
> >
> >        AS_AC_EXPAND(PLYMOUTH_LIBEXEC_DIR, $libexecdir)
> 
> So the original method is adding a line to the Makefile for every
> variable, this one is adding a line to configure.ac for every
> variable.  AS_AC_EXPAND doesn't seem like an obvious win to me over
> the original way.
> 
> Having said that, I don't have a strong opinion in favor of any of the
> three possible ways.  If you do have a less indifferent opinion about
> it, feel free to commit one of your proposed changes (the other
> changes in the patch are fine too).
> 
It'd actually work out as three lines per variable, since you'd need to
do it for each script.  Also the Makefile rule hits a slight snag when
you have a "," in your path (unlikely, admittedly :p) - since it breaks
the sed expression - config.status doesn't have this issue.

It also makes it consistent with how the .pc.in files get turned
into .pc files.


The main fix is to have the LIBEXECDIR and DATADIR variables in the
scripts actually come from configure - rather than being hardcoded.
That's the important bit ;-)

Scott
-- 
Scott James Remnant
scott at ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/plymouth/attachments/20100302/0218965d/attachment.pgp>