[PATCH] drm: fixed bug regarding minimal buffer size

Kevin Murphy kemurphy.cmu at gmail.com
Fri May 11 07:00:12 PDT 2012


And of course that time I missed the Reply All button....

Thanks,
Kevin

---------- Forwarded message ----------
From: *Kevin Murphy*
Date: Thursday, May 10, 2012
Subject: [PATCH] drm: fixed bug regarding minimal buffer size
To: Dave Airlie <airlied at gmail.com>


Ah, I thought I pasted it in....  My mistake.  Here it is, for real this
time :)

Thanks,
Kevin

On Thu, May 10, 2012 at 3:22 AM, Dave Airlie <airlied at gmail.com<javascript:;>>
wrote:
> On Thu, May 10, 2012 at 6:15 AM, Ray Strode <halfline at gmail.com<javascript:;>>
wrote:
>> Hey,
>>
>> On Wed, May 9, 2012 at 3:43 PM, Kevin Murphy <kemurphy.cmu at gmail.com<javascript:;>>
wrote:
>>> If we ask for a buffer of size 0 when testing for 32bpp framebuffer
>>> support, we trigger a condition in the kernel that will cause the
>>> test to fail, ultimately causing a fallback to the framebuffer
>>> driver.
>>> See
http://lxr.free-electrons.com/source/drivers/gpu/drm/ttm/ttm_bo.c#L1193
>>> for the block of code that gets triggered.
>>
>> Oh, bummer.  So ttm drivers report a min_width that's less than they
support?
>>
>>> Compiz ran into a similar
>>> issue at some point and they just forced each minimum dimension to 2
>>> if it detected it was about to ask for a 0, so that's the approach I
>>> took.
>> Sounds fine. I think you forgot to attach the patch though?
>
> Yeah a size > 0 is probably a good plan, I'll fix the kernel to not
> report 0 as well.
>
> Dave.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/plymouth/attachments/20120511/46cd4fe6/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-fixed-bug-regarding-minimal-buffer-size.patch
Type: application/octet-stream
Size: 1851 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/plymouth/attachments/20120511/46cd4fe6/attachment.obj>


More information about the plymouth mailing list