[PATCH] Trivial warning fixes
Alan Jenkins
alan.christopher.jenkins at gmail.com
Mon May 21 09:15:07 UTC 2018
Build showed some warnings.
The following warnings were trivial to remove.
ply-logger.c: In function ‘ply_logger_open_file’:
ply-logger.c:316:16: warning: unused variable ‘mode’ [-Wunused-variable]
mode_t mode;
^~~~
main.c: In function ‘plymouth_should_show_default_splash’:
main.c:905:20: warning: duplicate ‘const’ declaration specifier [-Wduplicate-decl-specifier]
const char const *strings[] = {
^~~~~
./plugin.c:395:19: warning: duplicate ‘const’ declaration specifier [-Wduplicate-decl-specifier]
static const char const *get_visual_name (int visual)
^~~~~
./plugin.c: In function ‘get_visual_name’:
./plugin.c:397:27: warning: duplicate ‘const’ declaration specifier [-Wduplicate-decl-specifier]
static const char const *visuals[] =
^~~~~
---
src/libply/ply-logger.c | 1 -
src/main.c | 2 +-
src/plugins/renderers/frame-buffer/plugin.c | 4 ++--
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/libply/ply-logger.c b/src/libply/ply-logger.c
index 1b56ea8..e9b90de 100644
--- a/src/libply/ply-logger.c
+++ b/src/libply/ply-logger.c
@@ -313,7 +313,6 @@ ply_logger_open_file (ply_logger_t *logger,
const char *filename)
{
int fd;
- mode_t mode;
assert (logger != NULL);
assert (filename != NULL);
diff --git a/src/main.c b/src/main.c
index 08c7fe1..ba6546c 100644
--- a/src/main.c
+++ b/src/main.c
@@ -902,7 +902,7 @@ plymouth_should_show_default_splash (state_t *state)
{
ply_trace ("checking if plymouth should show default splash");
- const char const *strings[] = {
+ const char *const strings[] = {
"single", "1", "s", "S", "-S", NULL
};
int i;
diff --git a/src/plugins/renderers/frame-buffer/plugin.c b/src/plugins/renderers/frame-buffer/plugin.c
index 41ad6cd..9c863d4 100644
--- a/src/plugins/renderers/frame-buffer/plugin.c
+++ b/src/plugins/renderers/frame-buffer/plugin.c
@@ -392,9 +392,9 @@ close_device (ply_renderer_backend_t *backend)
backend->head.area.height = 0;
}
-static const char const *get_visual_name (int visual)
+static const char *get_visual_name (int visual)
{
- static const char const *visuals[] =
+ static const char *const visuals[] =
{
[FB_VISUAL_MONO01] = "FB_VISUAL_MONO01",
[FB_VISUAL_MONO10] = "FB_VISUAL_MONO10",
--
2.14.3
More information about the plymouth
mailing list