[PATCH] Easy warning fix in ply-device-manager
Alan Jenkins
alan.christopher.jenkins at gmail.com
Mon May 21 09:15:40 UTC 2018
ply-device-manager.c: In function ‘create_devices_for_terminal_and_renderer_type’:
ply-device-manager.c:704:33: warning: ‘return’ with no value, in function returning non-void
return;
^~~~~~
There's an earlier path "ignoring device %s since it's already managed"
which returns true. This second early-return has the same message. I think
it also wants to return true.
---
src/libply-splash-core/ply-device-manager.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/libply-splash-core/ply-device-manager.c b/src/libply-splash-core/ply-device-manager.c
index fbf4723..210caa0 100644
--- a/src/libply-splash-core/ply-device-manager.c
+++ b/src/libply-splash-core/ply-device-manager.c
@@ -696,12 +696,12 @@ create_devices_for_terminal_and_renderer_type (ply_device_manager_t *manager,
(void *) ply_renderer_get_device_name (renderer));
if (old_renderer != NULL) {
- ply_trace ("ignoring device %s since it's alerady managed",
+ ply_trace ("ignoring device %s since it's already managed",
ply_renderer_get_device_name (renderer));
ply_renderer_free (renderer);
renderer = NULL;
- return;
+ return true;
}
}
}
--
2.14.3
More information about the plymouth
mailing list