[PATCH] logger: remove unused code

[Alan Jenkins]

ply_logger_get_default() is unused.  Unused code can be confusing and
untested.  Remove it.

Logging to both STDOUT_FILENO and STDERR_FILENO requires care.  Generally
you want to flush your buffer for stdout before writing to stderr, in case
they are redirected to the same file.  We did no such thing.

Also we have some code that redirects ply_logger_get_error_default(), while
ignoring ply_logger_get_default().

FWIW the stdout output would log unchanged... if tracing was enabled
meaning we didn't just close stdout.  This could be undesirable, stdout
might be connected to the console which we redirect to ourself, or some
logging infrastructure which may create a circular dependency with logging
infrastructure that may write to the console (systemd / systemd-journald).
Removing the unused stdout log avoids having to make this analysis.

I'm sure we can continue to manage using only one log stream (and one debug
stream, and boot.log) :).
---
 src/libply/ply-logger.c | 13 -------------
 src/libply/ply-logger.h | 12 ------------
 2 files changed, 25 deletions(-)

diff --git a/src/libply/ply-logger.c b/src/libply/ply-logger.c
index e9b90de..7ffe585 100644
--- a/src/libply/ply-logger.c
+++ b/src/libply/ply-logger.c
@@ -241,19 +241,6 @@ ply_logger_new (void)
         return logger;
 }
 
-ply_logger_t *
-ply_logger_get_default (void)
-{
-        static ply_logger_t *logger = NULL;
-
-        if (logger == NULL) {
-                logger = ply_logger_new ();
-                ply_logger_set_output_fd (logger, STDOUT_FILENO);
-        }
-
-        return logger;
-}
-
 ply_logger_t *
 ply_logger_get_error_default (void)
 {
diff --git a/src/libply/ply-logger.h b/src/libply/ply-logger.h
index 53d1ad9..ae2f4de 100644
--- a/src/libply/ply-logger.h
+++ b/src/libply/ply-logger.h
@@ -106,18 +106,6 @@ bool ply_logger_is_tracing_enabled (ply_logger_t *logger);
 
 /* convenience macros
  */
-#define ply_open_log_file(filename)                                            \
-        ply_logger_open_file (ply_logger_get_default (), filename)
-#define ply_close_log_file()                                                   \
-        ply_logger_close_file (ply_logger_get_default ())
-#define ply_flush_log()                                                        \
-        ply_logger_flush (ply_logger_get_default ())
-#define ply_free_log()                                                         \
-        ply_logger_free (ply_logger_get_default ())
-#define ply_log(format, args ...)                                               \
-        ply_logger_inject (ply_logger_get_default (), format "\n", ## args)
-#define ply_log_without_new_line(format, args ...)                              \
-        ply_logger_inject (ply_logger_get_default (), format, ## args)
 #define ply_error(format, args ...)                                             \
         ply_logger_inject (ply_logger_get_error_default (), format "\n", ## args)
 #define ply_error_without_new_line(format, args ...)                            \
-- 
2.14.3