[Pm-utils] Re: Video adapter resuming

[David Zeuthen]

On Tue, 2006-11-28 at 00:01 +0000, Richard Hughes wrote:
> Okay, can you have a look at the sample file attached, and tell me what
> you guys think.
> 
> I'm in two mind about the 'contains=' match - I know computationally
> strstr is bigger compared to strcmp, but I'm trying to do as much binary
> division (by nesting the match statements) as possible to make the whole
> structure fit in as little amount of memory as possible.

At some point we're going to make the compiled fdi files reside in a
file we can mmap read-only so it's not really going to be dirty/writable
memory. As such, I wouldn't worry too much about the size though it's
always good to make things as small and simple as possible.

> Plus, with the new fdi matching, we should jump out of any non-matching
> branches fast, avoiding most of the contains= lines. I think the nested
> way is to go, in preference to doing a linear lookup of products.
> 
> What do you think?

Looks good to me. Please commit this and other fdi quirk files. Thanks!

Any chance we can get a pm-utils release that uses this anytime soon
btw? We'll need it for the 0.5.9 release scheduled for Dec 15 2006.

     David