[Pm-utils] [RFC] [patch review] Hook independence and security fixups, part 1

[Victor Lowther]

On Sat, 2008-02-02 at 14:55 +0100, Michael Biebl wrote:
> 2008/2/1, Victor Lowther <victor.lowther at gmail.com>:
> > Here are a few more patches in this series that add a
> > /usr/lib/pm-utils/config.d to go along with /etc/pm/config.d, the
> > needed changes to make functions aware of this, some modifications to
> > push certian generic environment variables into the new per-hook
> > configuration scheme, and how to override a suspend/resume method to
> > use something besides the default kernel methods without having to
> > patch the source to pm-utils.
> >
> > These patches apply on top of the last set of patches, or you can just
> > pull the (misnamed now) vlowther-security-audit branch from
> > git://fnordovax.org/pm-utils/
> >
> 
> Hm, tbh I find it a bit weird, that the do_hibernate method is now in
> a *config* file.
> Seems a bit counter-intuitive to me.
> Imo we should only set variables in config files.

tbh?

Also, note that the do_hibernate implementation in the pm-hibernate
config file is overriding the one defined in pm-functions, I did not
just move the function there.

> Cheers,
> Michael