[Pm-utils] [patch-commit] create directories and logfile

[Michael Biebl]

2008/1/30, Michael Biebl <mbiebl at gmail.com>:
> 2008/1/30, Stefan Seyfried <seife at suse.de>:
> > On Wed, Jan 30, 2008 at 12:49:22AM +0100, Till Maas wrote:
> > > Hiyas,
> > >
> > > here is a pathc with following changes:
> > >
> > >     - create logfile and used directories on install
> > >     - do not remove used directories, but clean them
> > >
> > > This patch makes sure that /var/run/pm-utils{,/storage} are created on make
> > > install
> >
> > Isn't this useless since /var/run is cleared at boot anyway (or was this some
> > other directory)?
>
> FHS only mandates that files in /var/run are cleared [1]. TTBOMK,
> directories are preserverd (unless you have a tmpfs on /var/run).
>

OTOH, I think Stefan is right.
For one, because you use a hard coded path in install-exec-local which
could be different to  STORAGEDIR and PM_LOGFILE defined in functions
(btw, shouldn't this variable definitions not better be moved to
defaults).
And second, we create those directories (with the correct path) anyway
in pm/functions.
So we better should leave that out of make install.

For the second half of the patch (not removing STORAGEDIR, only
cleaning it),  I'd say that's fine.

Cheers,
Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?