[Pm-utils] [patch-commit] create directories and logfile

[Till Maas]

On Wed January 30 2008, Michael Biebl wrote:
> 2008/1/30, Michael Biebl <mbiebl at gmail.com>:
> > 2008/1/30, Stefan Seyfried <seife at suse.de>:
> > > On Wed, Jan 30, 2008 at 12:49:22AM +0100, Till Maas wrote:
> > > > Hiyas,
> > > >
> > > > here is a pathc with following changes:
> > > >
> > > >     - create logfile and used directories on install
> > > >     - do not remove used directories, but clean them
> > > >
> > > > This patch makes sure that /var/run/pm-utils{,/storage} are created
> > > > on make install
> > >
> > > Isn't this useless since /var/run is cleared at boot anyway (or was
> > > this some other directory)?
> >
> > FHS only mandates that files in /var/run are cleared [1]. TTBOMK,
> > directories are preserverd (unless you have a tmpfs on /var/run).

Fedora for example does not remove directories in /var/run, but only files, 
but some special directories that may be there e.g. for samba, vmware.

> OTOH, I think Stefan is right.
> For one, because you use a hard coded path in install-exec-local which
> could be different to  STORAGEDIR and PM_LOGFILE defined in functions
> (btw, shouldn't this variable definitions not better be moved to
> defaults).

I can adjust the patch, so that STORAGEDIR and PM_LOGFILE is also created by 
autotools. Then there would be no difference. Btw. /etc/pm/* is also created 
on install but left empty. Imho it is better beheaviour when all directories 
that belong to the package are created on install, e.g. for rpm to own the 
directory, it must also exist.

Regards,
Till
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.freedesktop.org/archives/pm-utils/attachments/20080130/fb9ea0ce/attachment-0001.pgp