[Pm-utils] [Fwd: [Bug 15840] New: vbe_restoremode() does not work]

[Victor Lowther]

On Tue, 2008-05-06 at 09:56 +0100, Richard Hughes wrote:
> email message attachment, "Forwarded message - [Bug 15840] New:
> vbe_restoremode() does not work"
> > -------- Forwarded Message --------
> > From: bugzilla-daemon at freedesktop.org
> > To: richard at hughsie.com
> > Subject: [Bug 15840] New: vbe_restoremode() does not work
> > Date: Mon, 5 May 2008 23:09:14 -0700 (PDT)
> > 
> > http://bugs.freedesktop.org/show_bug.cgi?id=15840
> > 
> >            Summary: vbe_restoremode() does not work
> >            Product: pm-utils
> >            Version: unspecified
> >           Platform: x86 (IA32)
> >         OS/Version: Linux (All)
> >             Status: NEW
> >           Severity: normal
> >           Priority: medium
> >          Component: General
> >         AssignedTo: richard at hughsie.com
> >         ReportedBy: martin.pitt at ubuntu.com
> >                 CC: mjg59 at srcf.ucam.org
> > 
> > 
> > Hi!
> > 
> > In pm-utils 1.10, ./pm/sleep.d/99video has
> > 
> > vbe_savemode() { vbe vbemode get |savestate vbemode; }
> > vbe_restoremode() { vbe vbemode get |savestate vbemode; }
> > 
> > This is obviously a copy&paste error and should rather be
> > 
> > vbe_restoremode() { restorestate vbemode | vbe vbemode set; }
> > 
> > 
> > BTW, in the old 0.99.x versions, the Ubuntu package had a patch from Matthew
> > Garrett (in CC, author of vbetool) which special-cased mode 3:
> > 
> > -               vbe vbemode set `cat /var/run/vbemode`
> > +               vbemode=`cat /var/run/vbemode`
> > +               if [ $vbemode != "3" ]; then
> > +                       vbe vbemode set `cat /var/run/vbemode`
> > +               else
> > +                       vbe vgamode set 3
> > +               fi
> > 
> > I personally don't know what this does, and whether it is still needed.
> > Matthew, can you please explain this here? If it is still relevant, it should
> > be included upstream.
> > 
> > Thank you!
> > 

Patch applied to fd.o master branch for the VBE stuff.  I want to think
a bit more about the vga modesetting.

> _______________________________________________
> Pm-utils mailing list
> Pm-utils at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/pm-utils
-- 
Victor Lowther
Ubuntu Certified Professional